Skip to content

fix: unstable cypress#7104

Merged
luka-nextcloud merged 1 commit into
mainfrom
fix-unstable-cypress
Jul 15, 2025
Merged

fix: unstable cypress#7104
luka-nextcloud merged 1 commit into
mainfrom
fix-unstable-cypress

Conversation

@luka-nextcloud

Copy link
Copy Markdown
Contributor
  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@elzody

elzody commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Usually not a fan of using cy.wait(), what is the reason for it in this case?

@luka-nextcloud

Copy link
Copy Markdown
Contributor Author

Usually not a fan of using cy.wait(), what is the reason for it in this case?

@elzody I understand but I suspect the click event hadn't been bound yet at some point. That's why I try adding a short delay before performing the click action.

@elzody

elzody commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

... I suspect the click event hadn't been bound yet at some point.

Do you mean that the element was not visible yet and that the click event could not go through? Just a bit confused on what you mean by "hadn't been bound yet." I guess it's fine either way, just want to see if there is another way since this is considered an anti-pattern: https://docs.cypress.io/api/commands/wait#Time

@luka-nextcloud

@luka-nextcloud

Copy link
Copy Markdown
Contributor Author

@elzody Based on the Cypress report, we can see that the element is visible. However, when a click is performed, nothing happens. So, I suspect the click event listener on that element might not be ready yet.

@luka-nextcloud luka-nextcloud merged commit 60bba33 into main Jul 15, 2025
32 checks passed
@luka-nextcloud luka-nextcloud deleted the fix-unstable-cypress branch July 15, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants